fix: Remove direct GitHub API calls from frontend #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend was making direct calls to the GitHub API to check PR status, which was causing 403 errors. This change removes those direct API calls since the PR status is already included in the cached data that's built by the backend.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The tests were expecting the frontend to fetch PR status directly from GitHub API, but now that we've moved that logic to the backend, we need to update the tests to use the PR status from the cache instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
The frontend was making direct calls to the GitHub API to check PR status, which was causing 403 errors. This change removes those direct API calls since the PR status is already included in the cached data that is built by the backend.
Changes:
checkPRStatusfunction from frontend servicefetchBotActivitiessince it is already included in the cached dataThis should resolve the 403 errors since the frontend will no longer make any direct calls to the GitHub API.